Myles Borins
Notable Changes
- async_hooks:
- console:
- console.debug can now be used outside of the inspector (Benjamin Zaslavsky) #17033
- deps:
- module:
- module.builtinModules will return a list of built in modules (Jon Moss) #16386
- n-api:
- add helper for addons to get the event loop (Anna Henningsen) #17109
- process:
- src:
- embedders can now use Node::CreatePlatform to create an instance of NodePlatform (Cheng Zhao) #16981
- stream:
- writable.writableHighWaterMark and readable.readableHighWaterMark will return the values the stream object was instantiated with (Calvin Metcalf) #12860
- Added new collaborators
- maclover7 Jon Moss
- guybedford Guy Bedford
- hashseed Yang Guo
Commits
- [
623b589921] - tools/doc: add tools/remark-* to eslintignore (Ivan Wei) #17240 - [
cf0d7cfc46] - async_hooks: add destroy event for gced AsyncResources (Sebastian Mayr) #16998 - [
cf7e15cf78] - (SEMVER-MINOR) async_hooks: add trace events to async_hooks (Andreas Madsen) #15538 - [
e0ce7cf1e9] - (SEMVER-MINOR) async_wrap: add provider types for net server (Andreas Madsen) #17157 - [
cbd0be59f0] - benchmark: fix http/simple.js benchmark (Anatoli Papirovski) #17583 - [
120d756e47] - benchmark: refactor to use template string (Antonio V) #17313 - [
b16d570395] - benchmark: set maxHeaderListPairs in h2 headers.js (Anatoli Papirovski) #17194 - [
9ffdee811d] - benchmark: use unique filenames in fs benchmarks (Rich Trott) #16776 - [
ee84fc333d] - benchmark,path: remove unused variables (薛定谔的猫) #15789 - [
883281bca9] - buffer: don't predefine error (buji) #17021 - [
dcb53c10e2] - build: allow running configure from any directory (Gibson Fahnestock) #17321 - [
5d1463a0bc] - build: define HAVE_OPENSSL macro for cctest (Matheus Marchini) #17461 - [
4bb27a2db3] - build: add amake helpoption for common targets (Gibson Fahnestock) #17323 - [
5e0f39323f] - build: add serial commas to messages in configure script (Rich Trott) #17464 - [
742a4566ee] - build: fix test-v8 target (Michaël Zasso) #17269 - [
46c1d999d9] - build: add make lint-js-fix (Joyee Cheung) #17283 - [
0a40a1133d] - build: fix bsd build with gcc (Matheus Marchini) #16737 - [
0f727c07b9] - build: remove empty VCLibrarianTool entry (Daniel Bevenius) #17191 - [
09bd797711] - build: Allow linking against an external copy of nghttp2. (Ed Schouten) #16788 - [
9093392954] - build: do not build doc in source tarball (Joyee Cheung) #17100 - [
9a4abe47d5] - build: minor corrections to configure descriptions (Daniel Bevenius) #17094 - [
035a24e619] - build: enforce order of dependency when building addons (Joyee Cheung) #17048 - [
91385be239] - build: fix cctest target --with-dtrace (Daniel Bevenius) #17039 - [
2eec94489d] - Revert "build: for --enable-static, run only cctest" (Daniel Bevenius) #14986 - [
578d80b59b] - build: prevent echoing of recipes for test target (Daniel Bevenius) #17010 - [
5fc1e27e98] - build, win: faster Release rebuilds (Bartosz Sosnowski) #17393 - [
90a5e9f19b] - build,win: vcbuild refactoring call configure (Refael Ackermann) #17299 - [
87c885bd44] - build,win,msi: support WiX with VS2017 (João Reis) #17101 - [
23967b2713] - console: make dirxml an alias for console.log (Benjamin Zaslavsky) #17152 - [
40d4fee8d7] - console: add support for console.debug (Benjamin Zaslavsky) #17033 - [
4a5e32206a] - crypto: remove BIO_set_shutdown (Daniel Bevenius) #17542 - [
c951e2c7d4] - crypto: remove explicit qualifiers in Initialize (Daniel Bevenius) #17490 - [
8c2143091d] - crypto: do not reach into OpenSSL internals for ThrowCryptoError (David Benjamin) #16701 - [
49402b12d0] - crypto: declare int return type for set_field (Daniel Bevenius) #17468 - [
9e50f1721e] - crypto: use SetNull instead of Set (Daniel Bevenius) #17521 - [
e3df569d1c] - deps: upgrade libuv to 1.18.0 (cjihrig) #17282 - [
9f282ddaf7] - deps: cherry-pick 1420e44db0 from upstream V8 (Timothy Gu) #17344 - [
47cd49a8cb] - deps: backport 3c8195d from V8 upstream (Myles Borins) #17383 - [
465a32a087] - Revert "deps: cherry-pick 3c8195d from V8 upstream" (Myles Borins) #17383 - [
49d23a3021] - deps: V8: backport 14ac02c from upstream (Ali Ijaz Sheikh) #17512 - [
7c2a9bba64] - deps: patch V8 to 6.2.414.46 (Myles Borins) #17206 - [
04115724dc] - deps: cherry-pick 98c40a4bae915 from V8 upstream (Anna Henningsen) #17134 - [
7812c93a41] - deps: cherry-pick c690f54d95802 from V8 upstream (Anna Henningsen) #17134 - [
24bb99a808] - deps: cherry-pick upstream ICU fix (Mathias Bynens) #16931 - [
026f76024b] - dns: fix crash while setting server during query (XadillaX) #14891 - [
ccffbd96d1] - doc: fix modules.md export example (Anatoli Papirovski) #17579 - [
7e2fa5a2d6] - doc: add link to debugger in process.md (Delapouite) #17522 - [
a965dda849] - doc: simplify and clarify FIPS text in BUILDING.md (Rich Trott) #17538 - [
b015747156] - doc: esm loader example with module.builtinModules (Guy Bedford) #17385 - [
1eff647fd3] - doc: 'constructor' implies use of new keyword (Cameron Moorehead) #17364 - [
8a17b7b6f3] - doc: use correct and consistent typography for products (Rich Trott) #17492 - [
0a0a56aa34] - doc: add "Hello world" example for N-API (Franziska Hinkelmann) #17425 - [
865c4520b6] - doc: immprove inode text in fs.md (Rich Trott) #17519 - [
18d6dab19d] - doc: improve text for Console constructor (Rich Trott) #17519 - [
cb09959e8f] - doc: improve readability of README.md (Rich Trott) #17519 - [
0948238aa2] - doc: improve readability of COLLABORATOR_GUIDE.md (Rich Trott) #17519 - [
7f2764debb] - doc: add info on post-publishing ARM6 builds (Michael Dawson) #17455 - [
6aa6d418e2] - doc: mention node-test-pull-request-lite job (Jon Moss) #17513 - [
b8141a42d0] - doc: fix typo in repl.md (Rich Trott) #17502 - [
232a486c0c] - doc: fix common typo involving one-time listeners (Rich Trott) #17502 - [
07df234ea2] - doc: fix typo in dns.md (Rich Trott) #17502 - [
6c97f7fed5] - doc: use American spellings per style guide (Rich Trott) #17471 - [
35d492c428] - doc: remove unused link reference (Anatoli Papirovski) #17510 - [
e9ee168a3d] - doc: remove IPC channel implementation details (Bartosz Sosnowski) #17460 - [
7e38821df2] - doc: use arrow functions in util.md sample code (Mithun Sasidharan) #17459 - [
53ed05582a] - doc: update AUTHORS list (Michaël Zasso) #17452 - [
f7b0054b2b] - doc: use serial comma in tls.md (Rich Trott) #17464 - [
20dcbfce89] - doc: add serial comma in CPP_STYLE_GUIDE.md (Rich Trott) #17464 - [
01be9462d5] - doc: edit module introduction (Rich Trott) #17463 - [
4fff2ab7ca] - doc: standardize preposition usage in fs.md (Rich Trott) #17463 - [
f3ec355123] - doc: improve punctuation in fs.open() text (Rich Trott) #17463 - [
ef7444cc94] - doc: use colon consistently in assert.md (Rich Trott) #17463 - [
cd7cee57e9] - doc: update example in module registration (Franziska Hinkelmann) #17424 - [
d3e76e78ff] - doc: introduce categories to Cpp style guide (Franziska Hinkelmann) #17095 - [
e00923bf5e] - doc: add missing serial commas (Rich Trott) #17384 - [
9df52dd115] - doc: be concise about serial commas (Rich Trott) #17384 - [
7849d53158] - doc: document tls.checkServerIdentity (Hannes Magnusson) #17203 - [
a596577a31] - doc: improve checkServerIdentity docs (Hannes Magnusson) #17203 - [
2a4f4f8125] - doc: add guide to maintaining npm (Myles Borins) #16541 - [
3807c6887a] - doc: fix doc example for cctest (Matheus Marchini) #17355 - [
bd55a79422] - doc: clarify fast-track of reversions (Refael Ackermann) #17332 - [
dcd87acb7b] - doc: make error descriptions more concise (Rich Trott) #16954 - [
cc91a00af6] - doc: fix typo in stream.md (Matthew Leon) #17357 - [
048878288b] - doc: non-partitioned async crypto operations (Jamie Davis) #17250 - [
0443909848] - doc: move Code of Conduct to admin repo (Myles Borins) #17301 - [
5756d67f95] - doc: fix typo occuring -> occurring (Leko) #17350 - [
94be7fdfec] - doc: Add link for ECMAScript 2015 (smatsu-hl) #17317 - [
a0acd91470] - doc: caution against removing pseudoheaders (James M Snell) #17329 - [
2bd241e974] - doc: replace string with template string (Leko) #17316 - [
0b1448897d] - doc: replace function with arrow function in vm.md (narirou) #17307 - [
078b4a625b] - doc: replace function with arrow function (Leko) #17304 - [
4fafeae4a2] - doc: update maintainting V8 guide (Michaël Zasso) #17260 - [
524db29844] - doc: fix typo in api doc of url.format(urlObject) (pkovacs) #17295 - [
c901ccec40] - doc: add ES Modules entry to who-to-cc (Rich Trott) #17205 - [
e45c9c651a] - doc: add maclover7 to collaborators (Jon Moss) #17289 - [
f13667221b] - doc: update http URLs to https in README.md (Ronald Eddy Jr) #17264 - [
c67612963c] - doc: update http URLs to https in doc/api (Ronald Eddy Jr) #17263 - [
c345a107a6] - doc: update http URLs to https in GOVERNANCE.md (Ronald Eddy Jr) #17262 - [
f3c5f76fe8] - doc: update http URLs to https in CONTRIBUTING.md (Ronald Eddy Jr) #17261 - [
df5436cee1] - doc: add SharedArrayBuffer to Buffer documentation (Thomas den Hollander) #15489 - [
821951e2a9] - doc: document resolve hook formats (Lucas Azzola) #16375 - [
04c4c1f260] - doc: fs.readFile is async but not partitioned (Jamie Davis) #17154 - [
74506f72e6] - doc: add description for inspector-only console methods. (Benjamin Zaslavsky) #17004 - [
1a3aadb2e9] - doc: use better terminology for build machines (Anna Henningsen) #17142 - [
2fccf84015] - doc: use "JavaScript" instead of "Javascript" (Rich Trott) #17163 - [
9dcf748000] - doc: prepare for v8/V8 linting in doc text (Rich Trott) #17163 - [
bd1dbcef85] - doc: add capitalization styling to STYLE_GUIDE (Rich Trott) #17163 - [
68870161cc] - doc: update mgol in AUTHORS.txt, add to .mailmap (Michał Gołębiowski-Owczarek) #17239 - [
ef4c909335] - doc: update release table in V8 guide (Ali Ijaz Sheikh) #17136 - [
3f363d3cda] - doc: add guybedford to collaborators (Guy Bedford) #17197 - [
7b5a05bc0f] - doc: update AUTHORS list (Michaël Zasso) #16571 - [
4c23e6a8c7] - doc: normalize ToC indentation with heading levels in README (Rich Trott) #17106 - [
f1d19d5eb9] - doc: add Contributing to Node.js to the README ToC (Rich Trott) #17106 - [
fa82f3a5c4] - doc: merge Working Groups with Contributing to Node.js in README (Rich Trott) #17106 - [
39cfecd568] - doc: remove IRC node-dev link from README (Rich Trott) #17106 - [
976ed7507b] - doc: add missing introduced_in comments (Luigi Pinca) #16741 - [
39cb687ee5] - doc: change v8 to V8 (Rich Trott) #17089 - [
4b35dfbb31] - doc: avoid mentioning 'uncaughtException' (Luigi Pinca) #16905 - [
18b08f082a] - doc: add note about using cluster without networking (pimlie) #17031 - [
2f34d35b0a] - doc: explicitly document highWaterMark option (Sebastian Silbermann) #17049 - [
c917cd6fdd] - doc: fix a link in dgram.md (Vse Mozhet Byt) #17107 - [
a12bc2df0e] - doc: reorganize collaborator guide (Joyee Cheung) #17056 - [
4a9c75a279] - doc: delete unused definition in README.md (Vse Mozhet Byt) #17108 - [
378439e2cb] - doc: add Support section in README (Rich Trott) #16533 - [
8dc05e4630] - doc: document common pattern for instanceof checks (Michael Dawson) #16699 - [
03803ee505] - doc: mention smart pointers in Cpp style guide (Franziska Hinkelmann) #17055 - [
b87030c5cf] - doc: correct the wrong added meta data (Gaara) #17072 - [
73295370cc] - doc: document fs.realpath.native() (Ben Noordhuis) #17059 - [
4bdd05dd84] - doc: add Table of Contents to Cpp style guide (Franziska Hinkelmann) #17052 - [
7d49bd0045] - doc: addclientCertEngineto docs (Rich Trott) - [
7594032fac] - doc: add hashseed to collaborators (Yang Guo) - [
a256482318] - doc,test: remove unnecessary await with return instances (Rich Trott) #17265 - [
bccdea623d] - doc,win: clarify WSL support (João Reis) #17008 - [
9b16e15f44] - domain: re-implement domain over async_hook (vladimir) #16222 - [
9c2f24e288] - errors: fix typo in TLS_SESSION_ATTACK message (Tom Hallam) #17388 - [
a333e71342] - errors: consistent format for error message (Anatoli Papirovski) #16904 - [
715baf8214] - fs: use rest param & Reflect.apply in makeCallback (Mithun Sasidharan) #17486 - [
7ebaf83602] - fs: use arrow functions instead of.bindandself(Weijia Wang) #17137 - [
24dc57bc71] - http: simplify checkIsHttpToken() (Rich Trott) #17399 - [
5a4b6c4bc0] - http: do not assign intermediate variable (Jon Moss) #17335 - [
a6b6acb68c] - http, stream: writeHWM -> writableHighWaterMark (Matteo Collina) #17050 - [
658338e317] - http2: use more descriptive names (James M Snell) #17328 - [
4994d57890] - http2: remove unnecessary event handlers (James M Snell) #17328 - [
67abc1e697] - http2: reduce code duplication in settings (James M Snell) #17328 - [
e5f92cda7e] - http2: general cleanups (James M Snell) #17328 - [
54cd7dfd88] - inspector: Fix crash for WS connection (Eugene Ostroukhov) #17085 - [
94e0488a33] - inspector: no async tracking for promises (Anna Henningsen) #17118 - [
8fd316f63b] - internal: add emitExperimentalWarning function (Cody Deckard) #16497 - [
1a8b0e9fa5] - lib: replace string concatenation with template (Vijayalakshmi Kannan) #16923 - [
b719b77215] - module: print better message on esm syntax error (Ben Noordhuis) #17281 - [
5736dc4ab9] - module: fix for #17130 shared loader cjs dep (Guy Bedford) #17131 - [
06da8a7f16] - module: be lazy when creating CJS facades (Bradley Farias) #17153 - [
7ae7124039] - (SEMVER-MINOR) module: add builtinModules (Jon Moss) #16386 - [
caff930d47] - module: replace default paths in require.resolve() (cjihrig) #17113 - [
b833a5989c] - n-api: use nullptr instead of NULL in node_api.cc (Daniel Bevenius) #17276 - [
8d222d42ab] - (SEMVER-MINOR) n-api: add helper for addons to get the event loop (Anna Henningsen) #17109 - [
8366a74bbf] - path: remove obsolete comment (Rich Trott) #17023 - [
a159a2c6ac] - process: slight refinements to nextTick (Anatoli Papirovski) #17421 - [
347164a703] - (SEMVER-MINOR) process: add flag for uncaught exception abort (Anna Henningsen) #17159 - [
9d657247df] - process: slightly simplify next tick execution (Anatoli Papirovski) #16888 - [
8d90db5120] - (SEMVER-MINOR) process: Send signal name to signal handlers (Robert Rossmann) #15606 - [
9a9aa88797] - process: improve unhandled rejection message (Madara Uchiha) #17158 - [
8dcc40a84f] - src: remove unused include node_crypto_clienthello (Daniel Bevenius) #17546 - [
fb3ea4c4dc] - src: fix missing handlescope bug in inspector (Ben Noordhuis) #17539 - [
40acda2e6b] - src: use uv_os_getpid() to get process id (cjihrig) #17415 - [
9b41c0b021] - src: node_http2_state.h should not be executable (Jon Moss) #17408 - [
419cde79b1] - src: use non-deprecated versions of->To*()utils (Leko) #17343 - [
ceda8c57aa] - src: use nullptr instead of NULL (Daniel Bevenius) #17373 - [
7f55f98a84] - src: fix typo in NODE_OPTIONS whitelist (Evan Lucas) #17369 - [
9b27bc85ae] - src: introduce USE() for silencing compiler warnings (Anna Henningsen) #17333 - [
0db1f87825] - src: use NODE_BUILTIN_MODULE_CONTEXT_AWARE() macro (Ben Noordhuis) #17071 - [
6a7a59a8c1] - src: removeClearFatalExceptionHandlers()(Anna Henningsen) #17333 - [
9c7a42a2e4] - src: explicitly register built-in modules (Yihong Wang) #16565 - [
4667c5e720] - src: start heap object tracking after platform is initialized (Hannes Payer) #17249 - [
63f6947a41] - src: make base64.h self-contained (Daniel Bevenius) #17177 - [
14ebda5218] - (SEMVER-MINOR) src: add public API for managing NodePlatform (Cheng Zhao) #16981 - [
9832b8e206] - src: add napi_handle_scope_mismatch to msg list (neta) #17161 - [
0b128842f6] - src: fix compiler warning (cjihrig) #17195 - [
9c0c33625a] - src: remove unprofessional slang in assertions (Alexey Orlenko) #17166 - [
936c0b2b83] - src: implement v8::TaskRunner API in NodePlatform (Anna Henningsen) #17134 - [
a9be7bf35b] - src: remove unused variable (cjihrig) #17150 - [
84b707089e] - (SEMVER-MINOR) src: add helper for addons to get the event loop (Anna Henningsen) #17109 - [
362b8c7d5d] - src: inspector context name = program title + pid (Ben Noordhuis) #17087 - [
7ecec6704f] - src: abstract getpid() operation (Ben Noordhuis) #17087 - [
e7db034571] - src: add NODE_VERSION_IS_LTS to node_version.h (Gibson Fahnestock) #16697 - [
60423f5845] - src: use unique_ptr for http2_state (Franziska Hinkelmann) #17078 - [
e9000901ca] - src: add missing include in node_platform.h (Anna Henningsen) #17133 - [
1b76cfe3c2] - src: use unique_ptr for scheduled delayed tasks (Franziska Hinkelmann) #17083 - [
af63df80b4] - src: use std::unique_ptr in base-object-inl.h (Franziska Hinkelmann) #17079 - [
4387a73514] - src: remove superfluous check in backtrace_posix.cc (Anna Henningsen) #16950 - [
3ab3b0d4e2] - src: fix size of CounterSet (Witthawat Piwawatthanapanit) #16984 - [
d74c7c5461] - src: rename req-wrap -> req_wrap (Daniel Bevenius) #17022 - [
5119bb1a6d] - src: rename base-object -> base_object (Daniel Bevenius) #17022 - [
8ba513ee2e] - src: rename async-wrap -> async_wrap (Daniel Bevenius) #17022 - [
da8414e09a] - src: use smart pointer instead of new and delete (Franziska Hinkelmann) #17020 - [
17e31dc66a] - src: perf_hooks: fix wrong sized delete (Ali Ijaz Sheikh) #16898 - [
a1a99570aa] - src: make ownership of stdio_pipes explicit (Franziska Hinkelmann) #17030 - [
98a07709f4] - src: use unique pointer for tracing_agent (Franziska Hinkelmann) #17012 - [
a05c49c48d] - src: use unique_ptr for requests in crypto (Franziska Hinkelmann) #17000 - [
6f805c6967] - src: implement backtrace-on-abort for windows (Anna Henningsen) #16951 - [
7ac760b603] - src: fix SetClientCertEngine() nullptr dereference (Ben Noordhuis) #16965 - [
f6ec5fa4e8] - src: fix bad sizeof expression (Ben Noordhuis) #17014 - [
8522e2420d] - src: use unique_ptr in platform implementation (Franziska Hinkelmann) #16970 - [
c2431d553b] - src: cancel pending delayed platform tasks on exit (Anna Henningsen) #16700 - [
37a60a8c3c] - src: prepare v8 platform for multi-isolate support (Anna Henningsen) #16700 - [
b36c726206] - stream: improve the error message ofERR_INVALID_ARG_TYPE(Weijia Wang) #17145 - [
78b82b03c5] - stream: use arrow fns for 'this' in readable (Vipin Menon) #16927 - [
edb9846884] - (SEMVER-MINOR) stream: remove usage of *State.highWaterMark (Calvin Metcalf) #12860 - [
e7ae8eb457] - test: refactor test-child-process-pass-fd (Rich Trott) #17596 - [
5a9172fe06] - test: remove unnecessary use of common.PORT in addons test (Rich Trott) #17563 - [
39e2fb6ad4] - test: simplify common.PORT code (Rich Trott) #17559 - [
f45ef442bb] - test: refactor test-http-default-port (Anna Henningsen) #17562 - [
49d662846e] - test: replace assert.throws w/ common.expectsError (Anatoli Papirovski) #17557 - [
f7e5ab082d] - test: refactored to remove unnecessary variables (Mithun Sasidharan) #17553 - [
bb780d2d84] - test: use Countdown in http-agent test (Federico Kauffman) #17537 - [
510116ebe6] - test: update http test to use common.mustCall (Collins Abitekaniza) #17528 - [
39d8e4413a] - test: improve assert messages in repl-reset-event (Adri Van Houdt) #16836 - [
6576382eaa] - test: update test-http-should-keep-alive to use countdown (TomerOmri) #17505 - [
f3d619882e] - test: fix flaky test-benchmark-es (Rich Trott) #17516 - [
ff59d3a30e] - test: replace assert.throws w/ common.expectsError (Mithun Sasidharan) #17483 - [
28b2d8ac20] - test: use common.expectsError in tests (Mithun Sasidharan) #17484 - [
d15cdc6fdb] - test: replace assert.throws w/ common.expectsError (Mithun Sasidharan) #17498 - [
993b1cbc6d] - test: use Countdown in http test (idandagan1) #17506 - [
1aae28b7c9] - test: use Number.isNaN instead of global isNaN (Mithun Sasidharan) #17515 - [
2a5da9c2c9] - test: use Countdown in http-response-statuscode (Mandeep Singh) #17327 - [
919625bd6a] - test: use Countdown in test-http-set-cookies (Shilo Mangam) #17504 - [
f399667784] - test: replace assert.throws w/ common.expectsError (Mithun Sasidharan) #17497 - [
c2ff36ed7f] - test: replace assert.throws w/ common.expectsError (Mithun Sasidharan) #17494 - [
af8e27d10e] - test: Use common.mustCall in http test (sreepurnajasti) #17487 - [
7b8622f946] - test: update http test to use Countdown (Francisco Gerardo Neri Andriano) #17477 - [
fb553b5b59] - test: improve crypto test coverage (Leko) #17426 - [
928aecc92c] - test: replace fs.accessSync with fs.existsSync (Leko) #17446 - [
7d3a84388d] - test: fix flaky test-benchmark-querystring (Rich Trott) #17517 - [
50f120eaac] - test: fix flaky test-benchmark-util (Rich Trott) #17473 - [
a407a48bdf] - test: expand coverage for crypto (Leko) #17447 - [
07547346a8] - test: add common.crashOnUnhandledRejection() (IHsuan) #17247 - [
8c32b4a37a] - test: refactor code to use common.mustCall (Mithun Sasidharan) #17437 - [
fe9d9f732b] - test: remove hidden use of common.PORT in parallel tests (Rich Trott) #17466 - [
cca3526faf] - test: add more settings to test-benchmark-dgram (Rich Trott) #17462 - [
562007ce2a] - test: add dgram bench
0 Comments
Log in to join the conversation.No comments yet. Be the first to share your thoughts.